From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-f67.google.com (mail-lf1-f67.google.com [209.85.167.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 381F946970E for ; Wed, 5 Feb 2020 01:15:58 +0300 (MSK) Received: by mail-lf1-f67.google.com with SMTP id c23so13369674lfi.7 for ; Tue, 04 Feb 2020 14:15:58 -0800 (PST) Date: Wed, 5 Feb 2020 01:15:56 +0300 From: Konstantin Osipov Message-ID: <20200204221556.GE20146@atlas> References: <20200128192249.10023-1-gorcunov@gmail.com> <20200128192249.10023-3-gorcunov@gmail.com> <20200203143928.GG547@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200203143928.GG547@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH v7 2/5] box/applier: add missing diag_set on region_alloc failure List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Sergey Ostanevich Cc: tml * Sergey Ostanevich [20/02/03 17:42]: > Hi! > > Thanks for the patch! > > LGTM. This code is dead actually. There is no region quota and OOM is impossible here. We haven't had a policy to check these errors before. No harm in pushing it, but no value either. -- Konstantin Osipov, Moscow, Russia