From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <korablev@tarantool.org>
Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id D912646970E
 for <tarantool-patches@dev.tarantool.org>;
 Tue,  4 Feb 2020 15:56:39 +0300 (MSK)
Date: Tue, 4 Feb 2020 15:56:37 +0300
From: Nikita Pettik <korablev@tarantool.org>
Message-ID: <20200204125637.GB62548@tarantool.org>
References: <55e18164c96a568a757423df813dc4e73f45b1c9.1577782147.git.imeevma@gmail.com>
 <20191231085607.GB30188@tarantool.org>
 <20191231094611.GA9514@tarantool.org>
 <20200113125829.GB7851@tarantool.org>
 <20200117080636.GA23812@tarantool.org>
 <20200122132617.GA1144@tarantool.org>
 <20200123134040.GA18715@tarantool.org>
 <20200128162329.GA1049@tarantool.org>
 <20200203095210.GA7696@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20200203095210.GA7696@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v2 1/1] sql: make NUMBER to be union
	of SQL numeric types
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Mergen Imeev <imeevma@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org

On 03 Feb 12:52, Mergen Imeev wrote:
> On Tue, Jan 28, 2020 at 07:23:29PM +0300, Nikita Pettik wrote:
> > On 23 Jan 16:40, Mergen Imeev wrote:
> > > Hi! Thank you for review. My answers and new commit-message
> > > below.
> > 
> > Hi,
> > 
> > I've a bit reworked your patch: splitted it into consistent sequence of
> > independent patches and provided refactoring for sqlVdbeMemNumerify().
> > Also I found that CAST boolean AS NUMBER didn't work properly: cast resulted
> > in error meanshile cast boolean as integer is legal, so that as number should
> > be legal as well. There's no more functional changes except for mentioned one.
> > Please look at branch: https://github.com/tarantool/tarantool/commits/np/gh-4233-fix-number-field-type-in-sql
> > 
> > If it is OK to you please reply and I will push patches to master bracnch.
> > Thanks. 
> >  
> Hi,
> 
> I'm sorry, but I do not like it.

Fair review.

> Since now it is yours
> commits, I'll ask Sasha to move issues #4233 and #4463
> to you. If you want a review, please ask Vlad.

Okay, let's spend one more iteration cycle.