From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gorcunov@gmail.com>
Received: from mail-lf1-f66.google.com (mail-lf1-f66.google.com
 [209.85.167.66])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 6A70446970E
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 31 Jan 2020 22:57:26 +0300 (MSK)
Received: by mail-lf1-f66.google.com with SMTP id n25so5749199lfl.0
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 31 Jan 2020 11:57:26 -0800 (PST)
Date: Fri, 31 Jan 2020 22:57:23 +0300
From: Cyrill Gorcunov <gorcunov@gmail.com>
Message-ID: <20200131195723.GA12445@uranus>
References: <20200124151706.18482-1-gorcunov@gmail.com>
 <20200131194448.GA17326@atlas>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200131194448.GA17326@atlas>
Subject: Re: [Tarantool-patches] [PATCH] box/txn: do not zap fiber txn
 pointer before txn_write_to_wal completes
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Konstantin Osipov <kostja.osipov@gmail.com>
Cc: tml <tarantool-patches@dev.tarantool.org>

On Fri, Jan 31, 2020 at 10:44:48PM +0300, Konstantin Osipov wrote:
> 
> I believe Georgy added this for a reason - since the current fiber
> is no longer locked until the transaction is resumed, it should
> be removed from the fiber key (this change AFAIU comes from
> parallel applier patch).
> 
> I suggest you move this statement inside txn_write_to_wal(). I
> can't find a good place for it yet though.

Thanks for idea, Kostya! The my patch above didn't work simply
because if I don't set NULL here it start triggering assertion
in another places. IOW, I filed this issue and will back to
it on the next week I hope. I'll show you the result.