From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <korablev@tarantool.org>
Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id C7FD446970E
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 31 Jan 2020 03:24:12 +0300 (MSK)
Date: Fri, 31 Jan 2020 03:24:11 +0300
From: Nikita Pettik <korablev@tarantool.org>
Message-ID: <20200131002411.GA62548@tarantool.org>
References: <20191202161128.20890-1-bokuno@picodata.io>
 <1578908907.647593657@f120.i.mail.ru>
 <20200115173619.GF7851@tarantool.org>
 <1579863862.443401751@f420.i.mail.ru>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <1579863862.443401751@f420.i.mail.ru>
Subject: Re: [Tarantool-patches] [PATCH] vinyl: prohibit
 vinyl_level_size_ratio less than two
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Maxim Kulis <bokuno@picodata.io>
Cc: tarantool-patches@dev.tarantool.org

On 24 Jan 14:04, Maxim Kulis wrote:
> 
> 
> Hi! 
> Yes, here is the new patch.
> 
> Change the minimum possible value of the variable vinyl_run_size_ratio to 2. 
> 
> Closes #3346
> 
> issue:  https://github.com/tarantool/tarantool/issues/3346
> ---

Put a link to the issue below '---' delimiter next time.

> >> >Finally, I would add brief explanation to the commit message why
> >> >run_size_ratio less than 2 is meaningless (for those who are not
> >> >familiar with vinyl inner organization).

Please, add a brief explanation to the commit message and then patch will
be OK to push. Thanks.