From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kyukhin@tarantool.org>
Received: from smtp3.mail.ru (smtp3.mail.ru [94.100.179.58])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 1836C46970E
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 30 Jan 2020 15:20:11 +0300 (MSK)
Date: Thu, 30 Jan 2020 15:20:11 +0300
From: Kirill Yukhin <kyukhin@tarantool.org>
Message-ID: <20200130122011.shdmnyp7g7xg7igg@tarantool.org>
References: <20200129014816.14248-1-bokuno@picodata.io>
 <20200129102813.3gsdeo27lmoh2zsi@tarantool.org>
 <20200129214603.GC31458@atlas>
 <20200130080223.tyta6lti4xsgwqcg@tarantool.org>
 <20200130083437.GD631@atlas>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20200130083437.GD631@atlas>
Subject: Re: [Tarantool-patches] [PATCH] small: unite the oscillation cache
 of all mempools
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Konstantin Osipov <kostja.osipov@gmail.com>, Maksim Kulis <bokuno@picodata.io>, tarantool-patches@dev.tarantool.org

Hello,

Thanks a lot for extensive comment.

On 30 янв 11:34, Konstantin Osipov wrote:
> PS It is of course possible to show that memory fragmentation has
> decreased with this patch by allocating a few objects and looking
> at memory stats. But such test will be fragile and thus bring more
> harm than good.

Small library is core of core. This is one of essential parts.
Our team @ MRG doesn't have a guy (or girl) who has enough
expertise to take responsibility and to accept such change
without a test.

The patch looks outstanding, but to start off a review process,
we need a test, sorry.

> 
> -- 
> Konstantin Osipov, Moscow, Russia

--
Regards, Kirill Yukhin