From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp37.i.mail.ru (smtp37.i.mail.ru [94.100.177.97]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 45D0546970E for ; Wed, 29 Jan 2020 13:28:14 +0300 (MSK) Date: Wed, 29 Jan 2020 13:28:13 +0300 From: Kirill Yukhin Message-ID: <20200129102813.3gsdeo27lmoh2zsi@tarantool.org> References: <20200129014816.14248-1-bokuno@picodata.io> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200129014816.14248-1-bokuno@picodata.io> Subject: Re: [Tarantool-patches] [PATCH] small: unite the oscillation cache of all mempools List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Maksim Kulis Cc: tarantool-patches@dev.tarantool.org Hello, On 29 янв 04:48, Maksim Kulis wrote: > The task is to unite the oscillation cache of all mempools. > In the function slab_put_with_order() we check if there is any > slab of the largest size except the current one, in order to > avoid oscillation. > https://github.com/tarantool/small/blob/master/small/slab_cache.c#L349 Thanks a lot for your patch. Since the change is performance related, before we start off review process, please provide a testcase (for tarantool or whatever) which will clearly show that there're cases where performance is actually increased. We won't accept "nice looking" perf patches. -- Regards, Kirill Yukhin