From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-f173.google.com (mail-lj1-f173.google.com [209.85.208.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 1144D46970E for ; Fri, 24 Jan 2020 18:24:27 +0300 (MSK) Received: by mail-lj1-f173.google.com with SMTP id h23so2898147ljc.8 for ; Fri, 24 Jan 2020 07:24:26 -0800 (PST) Date: Fri, 24 Jan 2020 18:24:24 +0300 From: Cyrill Gorcunov Message-ID: <20200124152424.GO2437@uranus> References: <20200124151706.18482-1-gorcunov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200124151706.18482-1-gorcunov@gmail.com> Subject: Re: [Tarantool-patches] [PATCH] box/txn: do not zap fiber txn pointer before txn_write_to_wal completes List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: tml On Fri, Jan 24, 2020 at 06:17:06PM +0300, Cyrill Gorcunov wrote: > The txn_write_to_wal operates with txn by own: on success it calls > txn_entry_done_cb which completes transaction, on error it calls > txn_rollback which expects the transaction we're rolling back is > the one the fiber carries in storage. Drop it, it start triggering another error. Thus need more significant investigation first.