From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <alexander.turenko@tarantool.org>
Received: from smtp43.i.mail.ru (smtp43.i.mail.ru [94.100.177.103])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 85D7946970E
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 24 Jan 2020 05:19:24 +0300 (MSK)
Date: Fri, 24 Jan 2020 05:19:30 +0300
From: Alexander Turenko <alexander.turenko@tarantool.org>
Message-ID: <20200124021930.ooxclznzptcbyl5j@tkn_work_nb>
References: <d1c6c24414cc165e1d990e171e2c9bd0824712e9.1575234056.git.v.shpilevoy@tarantool.org>
 <20191210141305.yu5nhjqztso5dcfb@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20191210141305.yu5nhjqztso5dcfb@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH decNumber 1/1] Fix build on Mac with
 gcc and XCode 11
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Kirill Yukhin <kyukhin@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org, Vladislav Shpilevoy <v.shpilevoy@tarantool.org>

On Tue, Dec 10, 2019 at 05:13:05PM +0300, Kirill Yukhin wrote:
> Hello,
> 
> On 01 дек 22:01, Vladislav Shpilevoy wrote:
> > There is a bug in XCode 11 which makes some standard C headers
> > not self sufficient. At least <stdlib.h> and <algorithm> are
> > affected. When they are included first, compilation fails with
> > creepy errors like this:
> > 
> >     In file included
> >     from /Applications/Xcode.app/Contents/Developer/
> >         Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/
> >         sys/wait.h:110,
> >     from /Applications/Xcode.app/Contents/Developer/
> >         Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/
> >         stdlib.h:66,
> >     from /Users/gerold/Work/Repositories/tarantool/third_party/
> >         zstd/lib/common/zstd_common.c:16:
> >         /Applications/Xcode.app/Content/Developer/
> >         Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/
> >         sys/resource.h:
> >     In function 'getiopolicy_np': /Applications/Xcode.app/Contents/Developer/
> >         Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/
> >         sys/resource.h:447:34: error:
> >             expected declaration specifiers before '__OSX_AVAILABLE_STARTING'
> >             447 | int     getiopolicy_np(int, int)
> >             __OSX_AVAILABLE_STARTING(__MAC_10_5, __IPHONE_2_0);
> > 
> > The patch workarounds the bug by changing header include order.
> > Part of https://github.com/tarantool/tarantool/issues/4580
> 
> Checked into master and bumped new version in Tarantool.

Are there a reason to don't push the bugfix to 2.2?

It will prevent clean applying of future updates of the submodule, so I
would prefer to update it everywhere.

WBR, Alexander Turenko.