From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id BA7AB46970E for ; Tue, 21 Jan 2020 17:27:55 +0300 (MSK) Date: Tue, 21 Jan 2020 17:25:39 +0300 From: Igor Munkin Message-ID: <20200121142539.GF26983@tarantool.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Subject: Re: [Tarantool-patches] [PATCH v2 0/2] add memory leaks detection via LSAN List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Alexander V. Tikhonov" Cc: tarantool-patches@dev.tarantool.org Sasha Ti., Thanks, LGTM. ### NB: AFAICS, there are also two more branches related to the issue: one for 1.10[1] and one for 2.2[2]. Please consider the following actions: * Explicitly specify the target branches for the current patchset * Adjust the braches for 1.10 and 2.2 regarding the comments I left for the first version of the series Sasha Tu. please proceed with the patchset. On 20.01.20, Alexander V. Tikhonov wrote: > Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-2058-asan-with-leaks > Issue: https://github.com/tarantool/tarantool/issues/2058 > > v1: https://lists.tarantool.org/pipermail/tarantool-patches/2020-January/013682.html > > Changes v2: > - made suggested corrections > > Changes v1: > - initial version > > Alexander V. Tikhonov (2): > test: use default replication connection timeout > gitlab-ci: add memory leaks detection via LSAN > > .travis.mk | 17 ++- > asan/asan.supp | 17 +++ > asan/lsan.supp | 105 ++++++++++++++++++ > cmake/profile.cmake | 4 +- > test/box/on_shutdown.skipcond | 7 ++ > test/replication/autobootstrap.lua | 2 - > test/replication/autobootstrap.result | 2 +- > test/replication/autobootstrap.test.lua | 2 +- > test/replication/autobootstrap_guest.lua | 2 - > test/replication/before_replace.result | 6 +- > test/replication/before_replace.test.lua | 6 +- > test/replication/ddl.lua | 2 - > test/replication/hot_standby.lua | 1 - > test/replication/master.lua | 1 - > test/replication/master_quorum.lua | 2 - > test/replication/on_replace.lua | 2 - > test/replication/quorum.lua | 2 - > test/replication/quorum.result | 15 ++- > test/replication/quorum.test.lua | 15 ++- > test/replication/rebootstrap.lua | 2 - > test/replication/rebootstrap.result | 4 +- > test/replication/rebootstrap.test.lua | 4 +- > test/replication/recover_missing_xlog.result | 2 +- > .../replication/recover_missing_xlog.test.lua | 2 +- > test/replication/replica.lua | 1 - > test/replication/replica_auth.lua | 2 - > test/replication/replica_no_quorum.lua | 1 - > test/replication/replica_quorum.lua | 2 - > test/replication/replica_timeout.lua | 2 - > test/replication/replica_uuid.lua | 1 - > test/replication/replica_uuid_ro.lua | 2 - > test/replication/replicaset_ro_mostly.result | 2 +- > .../replication/replicaset_ro_mostly.test.lua | 2 +- > test/replication/wal_off.lua | 1 - > 34 files changed, 172 insertions(+), 68 deletions(-) > create mode 100644 asan/asan.supp > create mode 100644 asan/lsan.supp > create mode 100644 test/box/on_shutdown.skipcond > > -- > 2.17.1 > [1]: https://github.com/tarantool/tarantool/tree/avtikhon/gh-2058-asan-with-leaks_1.10 [2]: https://github.com/tarantool/tarantool/tree/avtikhon/gh-2058-asan-with-leaks_2.2 -- Best regards, IM