From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gorcunov@gmail.com>
Received: from mail-lj1-f193.google.com (mail-lj1-f193.google.com
 [209.85.208.193])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id BA48046970E
 for <tarantool-patches@dev.tarantool.org>;
 Mon, 20 Jan 2020 13:59:12 +0300 (MSK)
Received: by mail-lj1-f193.google.com with SMTP id a13so33339458ljm.10
 for <tarantool-patches@dev.tarantool.org>;
 Mon, 20 Jan 2020 02:59:12 -0800 (PST)
Date: Mon, 20 Jan 2020 13:59:10 +0300
From: Cyrill Gorcunov <gorcunov@gmail.com>
Message-ID: <20200120105910.GD2437@uranus>
References: <20200117132929.11235-1-gorcunov@gmail.com>
 <20200117132929.11235-3-gorcunov@gmail.com>
 <20200120083148.GC19835@atlas>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200120083148.GC19835@atlas>
Subject: Re: [Tarantool-patches] [PATCH 2/2] box/applier: add missing
 diag_set on region_alloc failure
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Konstantin Osipov <kostja.osipov@gmail.com>
Cc: tml <tarantool-patches@dev.tarantool.org>

On Mon, Jan 20, 2020 at 11:31:48AM +0300, Konstantin Osipov wrote:
> * Cyrill Gorcunov <gorcunov@gmail.com> [20/01/17 16:32]:
> > In case if we're hitting memory limit allocting triggers
> > we should setup diag error to prevent nil dereference
> > in diag_raise call for example from applier_apply_tx.
> 
> It used to be region_alloc_xc, which would throw exception.
> 
> So it's a regression introduced by some of the "cleanup" patches.
> 
> Could you please find when it was introduced?

According to git logs region_alloc_xc has never been used here,
it indroduced by 8c84932ade1b70971890dfd27d72b3145834594b