From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-f65.google.com (mail-lf1-f65.google.com [209.85.167.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 87A7446970E for ; Mon, 20 Jan 2020 11:31:51 +0300 (MSK) Received: by mail-lf1-f65.google.com with SMTP id y1so23334213lfb.6 for ; Mon, 20 Jan 2020 00:31:51 -0800 (PST) Date: Mon, 20 Jan 2020 11:31:48 +0300 From: Konstantin Osipov Message-ID: <20200120083148.GC19835@atlas> References: <20200117132929.11235-1-gorcunov@gmail.com> <20200117132929.11235-3-gorcunov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200117132929.11235-3-gorcunov@gmail.com> Subject: Re: [Tarantool-patches] [PATCH 2/2] box/applier: add missing diag_set on region_alloc failure List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cyrill Gorcunov Cc: tml * Cyrill Gorcunov [20/01/17 16:32]: > In case if we're hitting memory limit allocting triggers > we should setup diag error to prevent nil dereference > in diag_raise call for example from applier_apply_tx. It used to be region_alloc_xc, which would throw exception. So it's a regression introduced by some of the "cleanup" patches. Could you please find when it was introduced? -- Konstantin Osipov, Moscow, Russia