From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <korablev@tarantool.org>
Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 2A13246970E
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 17 Jan 2020 22:15:29 +0300 (MSK)
Date: Fri, 17 Jan 2020 22:15:28 +0300
From: Nikita Pettik <korablev@tarantool.org>
Message-ID: <20200117191528.GD82780@tarantool.org>
References: <20200115165621.GB82780@tarantool.org>
 <20200116084125.28506-1-k.sosnin@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20200116084125.28506-1-k.sosnin@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH] sql: allow accessing list of
 collations via pragma
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Chris Sosnin <k.sosnin@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

On 16 Jan 11:41, Chris Sosnin wrote:
> Hi! Thank you for the review!
> 
> > Content returned by 'pragma collation_list' is already verified in
> > sql-tap/collation.test.lua. So I guess it is enough to check that
> > box.execute("pragma collation_list") does not throw an error.
> 
> I'm sorry, didn't notice such test exists. I changed the patch so it only
> checks for an error:
> +-- gh-4713 "PRAGMA collation_list" is not accessible to all users
> +_, err = box.execute('pragma collation_list')
> +assert(err == nil)
> 
> See the whole patch below.
> 
> 'pragma collation_list' uses _collation space, although user
> may have no access to it. Thus, we replace it with the
> corresponding view.
> 
> Closes #4713
> ---
> branch: https://github.com/tarantool/tarantool/tree/ksosnin/gh-4713-pragma-collation-list
> issue: https://github.com/tarantool/tarantool/issues/4713

Pushed to master, 2.2 and 2.3 branches. Thanks.