From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <alexander.turenko@tarantool.org>
Received: from smtp55.i.mail.ru (smtp55.i.mail.ru [217.69.128.35])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 7423646970E
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 17 Jan 2020 01:02:35 +0300 (MSK)
Date: Fri, 17 Jan 2020 01:02:39 +0300
From: Alexander Turenko <alexander.turenko@tarantool.org>
Message-ID: <20200116220239.re4nkbj5w62da6cg@tkn_work_nb>
References: <20200110154805.94649-1-olegrok@tarantool.org>
 <20200115112639.4rlwuxssjcshj65c@tkn_work_nb>
 <11e9b97a-3f3a-b3b0-5276-6e51468552da@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <11e9b97a-3f3a-b3b0-5276-6e51468552da@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v3] error: add __concat method to
	error object
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Oleg Babin <olegrok@tarantool.org>
Cc: Oleg Babin <babinoleg@mail.ru>, tarantool-patches@dev.tarantool.org

Sergey O. is okay too, so I'm going to push the patch.

Pushed to master, 2.3, 2.2 and 1.10.

WBR, Alexander Turenko.

On Wed, Jan 15, 2020 at 03:35:42PM +0300, Oleg Babin wrote:
> Thanks!
> 
> I've changed commit message and force pushed it to the top of my branch:
> https://github.com/tarantool/tarantool/tree/olegrok/4489-concat-for-errors
> 
> New commit message:
> 
> commit a9ad4bdfa51174223e0d10ef0b6a751fd15a6d8e (HEAD ->
> olegrok/4489-concat-for-errors, origin/olegrok/4489-concat-for-errors)
> Author: Oleg Babin <babinoleg@mail.ru>
> Date:   Fri Jan 10 18:35:03 2020 +0300
> 
>     error: add __concat method to error object
> 
>     Usually functions return pair `nil, err` and expected that err is
> string.
>     Let's make the behaviour of error object closer to string
>     and define __concat metamethod.
> 
>     The case of error "error_mt.__concat(): neither of args is an error"
>     is not covered by tests because of #4723
> 
>     Closes #4489
> 
> 
> On 15/01/2020 14:26, Alexander Turenko wrote:
> > LGTM.
> > 
> > Just two minor comments re commit message.
> > 
> 
> ---
> Oleg Babin