From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <korablev@tarantool.org>
Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 01F1846970E
 for <tarantool-patches@dev.tarantool.org>;
 Wed, 15 Jan 2020 20:29:44 +0300 (MSK)
Date: Wed, 15 Jan 2020 20:29:44 +0300
From: Nikita Pettik <korablev@tarantool.org>
Message-ID: <20200115172944.GC82780@tarantool.org>
References: <20200110074051.67668-1-k.sosnin@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20200110074051.67668-1-k.sosnin@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH] sql: fix assertion fail when
 selecting from _vfunc
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Chris Sosnin <k.sosnin@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

On 10 Jan 10:40, Chris Sosnin wrote:
> This patch already has LGTM from Vlad. However, I moved changes to
> the 2.3.2 upgrade, as long as the patch was no longer valid.
> 
> The assertion mentioned #4666 fails because it was forgotten to update
> _vfunc format along with _func in 2.2.1. This leads to bad allocation
> of vdbe cursor and setting wrong memory to 0.
> 
> Closes #4666
> ---
> branch: https://github.com/tarantool/tarantool/tree/ksosnin/gh-4666-select-from-vfunc
> issue: https://github.com/tarantool/tarantool/issues/4666

LGTM as well. Don't you forget edit snapshot in binary mode (asking
just in case)?