From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 2391D46970E for ; Wed, 15 Jan 2020 02:25:38 +0300 (MSK) Date: Wed, 15 Jan 2020 02:23:22 +0300 From: Igor Munkin Message-ID: <20200114232322.GL31304@tarantool.org> References: <11842f61682c057d3e11ff51c32f31e080fc2bea.1574324040.git.avtikhon@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <11842f61682c057d3e11ff51c32f31e080fc2bea.1574324040.git.avtikhon@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH v1 1/2] test: use default replication connection timeout List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Alexander V. Tikhonov" Cc: tarantool-patches@dev.tarantool.org Sasha, Thanks, the patch LGTM, though as discussed offline I see no relation to ASAN. So I propose to reword the commit message as the following: | All local connection timeout settings not related to the testing | scenario are removed within this change. Instead of removed values the | default one from src/box/lua/load_cfg.lua will be used. The approach | with a single default value helps to avoid flaky test results | regarding different timeout values and makes the future maintainence | easier. | | The change is required for LSAN and ASAN testing machinery since it | introduces a little overhead and cause failures for tests with | excessively strict time limits. | | Needed for #2058 Feel free to adjust it on your own way. On 21.11.19, Alexander V. Tikhonov wrote: > Removed all local connection timeout setups, where it is not the part > of the testing scenario. Instead of it the default value will be used. > Also it is more comfortable to change the single default value instead > of the change this value at each of the test scenarios, it will help > to avoid of flaky results in tests beacuse of different timeout vlaues. Typo: s/vlaues/values/. Typo: s/beacuse/because/. > The most of tests used the replication connection timeout is equal to > 0.5 second, while defualt value is set at sources file: Typo: s/defualt/default/. > src/box/lua/load_cfg.lua > to the value of 30 seconds: > replication_connect_timeout = 30 > which is quite enough for all of the tests that don't need any special > values for it. > > Part of #2058 > --- > -- > 2.17.1 > -- Best regards, IM