From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp14.mail.ru (smtp14.mail.ru [94.100.181.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id A3F7046970E for ; Tue, 14 Jan 2020 14:38:08 +0300 (MSK) Date: Tue, 14 Jan 2020 14:38:07 +0300 From: Kirill Yukhin Message-ID: <20200114113807.mc4yd2ngre2tmkqo@tarantool.org> References: <20200114104945.43008-1-k.sosnin@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200114104945.43008-1-k.sosnin@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH] box: frommap() bug fix List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Chris Sosnin Cc: tarantool-patches@dev.tarantool.org Hello, On 14 янв 13:49, Chris Sosnin wrote: > (backport version for 1.10) > This patch is almost the same as the one I've sent > for 2.3, the only difference is that here it is needed > to change tuple interface to make it possible to borrow > the error message after the luaT_tuple_new call. > > - If an optional argument is provided for > space_object:frommap() (which is {table = true|false}), > type match for first arguments is omitted, which is > incorrect. We should return the result only after making > sure it is possible to build a tuple. > > - If there is a type mismatch, however, frommap() does not > return nil, err as it is mentioned in the description, so we > change it to be this way. > > Closes #4262 > --- > branch: https://github.com/tarantool/tarantool/tree/ksosnin/gh-4262-frommap-fix-1-10 > issue: https://github.com/tarantool/tarantool/issues/4262 I've checked your patch into 1.10, 2.2, 2.3 and master. -- Regards, Kirill Yukhin