From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <imun@tarantool.org>
Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 9D6E946970E
 for <tarantool-patches@dev.tarantool.org>;
 Mon, 13 Jan 2020 20:04:35 +0300 (MSK)
Date: Mon, 13 Jan 2020 20:02:21 +0300
From: Igor Munkin <imun@tarantool.org>
Message-ID: <20200113170221.GK31304@tarantool.org>
References: <cover.1578916717.git.avtikhon@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <cover.1578916717.git.avtikhon@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v4 0/3] gitlab-ci: implement packing
	into MCS S3 v.4
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Sasha,

Thanks, you've fixed almost everything. Sorry, two my remarks were
slightly misleading, thus I extended them in the corresponding patch
in this patchset. Please consider them, since everything else LGTM.

I guess after the final fixes you can squash everithing into a single
commit and ask Sasha Tu to proceed with the patch.

On 13.01.20, Alexander V. Tikhonov wrote:
> Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-3380-push-packages-s3-full-ci
> Issue: https://github.com/tarantool/tarantool/issues/3380
> 
> v4: https://lists.tarantool.org/pipermail/tarantool-patches/2020-January/013568.html
> v3: https://lists.tarantool.org/pipermail/tarantool-patches/2019-December/013060.html
> v2: https://lists.tarantool.org/pipermail/tarantool-patches/2019-November/012352.html
> v1: https://lists.tarantool.org/pipermail/tarantool-patches/2019-October/012021.html
> 
> Changes v4:
> - minor corrections
> 
> Changes v3:
> - common code parts merged to standalone routines
> - corrected code style, minor updates
> - script is ready for release
> 
> Changes v2:
> - made changes in script from draft to pre-release stages
> 
> Alexander V. Tikhonov (3):
>   gitlab-ci: implement packing into MCS S3
>   Testing changes after 2nd review on S3
>   Testing changes after 3rd review on S3
> 
>  .gitlab-ci.yml            |   5 +-
>  .gitlab.mk                |  20 +-
>  .travis.mk                |  41 ++-
>  tools/add_pack_s3_repo.sh | 527 ++++++++++++++++++++++++++++++++++++++
>  4 files changed, 567 insertions(+), 26 deletions(-)
>  create mode 100755 tools/add_pack_s3_repo.sh
> 
> -- 
> 2.17.1
> 

-- 
Best regards,
IM