From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <imun@tarantool.org>
Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id C038746970E
 for <tarantool-patches@dev.tarantool.org>;
 Mon, 13 Jan 2020 15:31:09 +0300 (MSK)
Date: Mon, 13 Jan 2020 15:28:54 +0300
From: Igor Munkin <imun@tarantool.org>
Message-ID: <20200113122854.GH31304@tarantool.org>
References: <20200113121449.36540-1-huston.mavr@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20200113121449.36540-1-huston.mavr@gmail.com>
Subject: Re: [Tarantool-patches] [PATCH v2] fio: fix race condition in mktree
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: HustonMmmavr <huston.mavr@gmail.com>
Cc: tarantool-patches@dev.tarantool.org

Hello,

Thanks, LGTM.

Cced Sasha Tu. to proceed with the patch.

On 13.01.20, HustonMmmavr wrote:
> Despite the lack of documentation, fio.mktree() was designed to work
> similar to mkdir -p: it creates the directory along with it's parents
> and doesn't complain about existing ones.
> 
> But this function was subject to a race if two different processes were
> trying to create the same directory at the same time. It was caused by
> the fact that directory existence check and its creation aren't atomic.
> 
> This patch fixes the race by impoving error handling: it's not an error
> if directory exists, even if it was created by someone else and mktree
> failed.
> 
> Related to https://github.com/tarantool/doc/issues/1063

Side note: you can mention the ticket from other repo queue the
following way:
| Relates to tarantool/doc#1063

> Closes #4660
> ---
> branch: https://github.com/tarantool/tarantool/tree/HustonMmmavr/gh-4660-fix-fio-mktree-race
> 
>  src/lua/fio.lua | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/lua/fio.lua b/src/lua/fio.lua
> index cb224f3d0..c9aeac951 100644
> --- a/src/lua/fio.lua
> +++ b/src/lua/fio.lua
> @@ -364,7 +364,7 @@ fio.mktree = function(path, mode)
>          local stat = fio.stat(current_dir)
>          if stat == nil then
>              local st, err = fio.mkdir(current_dir, mode)
> -            if err ~= nil  then
> +            if err ~= nil and not fio.path.is_dir(current_dir) then
>                  return false, string.format("Error creating directory %s: %s",
>                      current_dir, tostring(err))
>              end
> -- 
> 2.23.0
> 

-- 
Best regards,
IM