From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-f67.google.com (mail-lf1-f67.google.com [209.85.167.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 05E5B46970E for ; Sun, 12 Jan 2020 12:27:17 +0300 (MSK) Received: by mail-lf1-f67.google.com with SMTP id r14so4710367lfm.5 for ; Sun, 12 Jan 2020 01:27:17 -0800 (PST) Date: Sun, 12 Jan 2020 12:27:14 +0300 From: Cyrill Gorcunov Message-ID: <20200112092714.GI2436@uranus> References: <20200110142749.11577-1-gorcunov@gmail.com> <43fa7862-777b-1717-71e0-ccb8865d23e5@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <43fa7862-777b-1717-71e0-ccb8865d23e5@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH] fiber: set diag error on madvise, mprotect fails List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Oleg Babin Cc: tarantool-patches@dev.tarantool.org On Sat, Jan 11, 2020 at 10:03:33AM +0300, Oleg Babin wrote: > Hello, thanks for your patch! > > Our documentation doesn't contain any mentions that fiber.create can fail. > > Could you please file an issue (or may be doc bot request) with > description in what cases user > > can expect that fiber.create will fail. Usually users don't use pcall for > fiber.create and this fact can > > be quite unexpected for them. > Actually we do have reference that fiber_new() can fail. https://www.tarantool.io/ru/doc/2.3/dev_guide/reference_capi/fiber/#c.fiber_new