From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <imun@tarantool.org>
Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id ABFAB46970E
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 10 Jan 2020 14:35:54 +0300 (MSK)
Date: Fri, 10 Jan 2020 14:33:40 +0300
From: Igor Munkin <imun@tarantool.org>
Message-ID: <20200110113340.GD31304@tarantool.org>
References: <20191217155223.13153-1-huston.mavr@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20191217155223.13153-1-huston.mavr@gmail.com>
Subject: Re: [Tarantool-patches] [PATCH] fio: fix race condition in mktree
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: HustonMmmavr <huston.mavr@gmail.com>
Cc: tarantool-patches@dev.tarantool.org

Hello,

Thanks for the patch. Here are some general comments for the patch:
* Why this patch is necessary? I see no words in documentation about the
  concurrent path creation and corresponding errors. Therefore
  considering our docs everything works as described. If you see this as
  a gray zone, please file a ticket to tarantool/doc[1] repo for
  adjusting the fio docs regarding the changes you provide.
* If you are affected with such behaviour please describe the problem
  you faced with a bit more words in the commit message (since the word
  "parallel" is ambigous for this case) and provide a test case
  regarding your fix if possible.

There are also several comments below, please also consider them.

On 17.12.19, HustonMmmavr wrote:
> This patch fixes a bug that occours when two instances calls

Typo: s/occours/occurs/.
Typo: s/calls/call/.

> fio.mktree for the same directory in parallel.
> 
> Closes #4660
> ---
> branch: https://github.com/tarantool/tarantool/tree/HustonMmmavr/gh-4660-fix-fio-mktree-race
> issue: https://github.com/tarantool/tarantool/issues/4660
> 
>  src/lua/fio.lua | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/lua/fio.lua b/src/lua/fio.lua
> index cb224f3d0..c9aeac951 100644
> --- a/src/lua/fio.lua
> +++ b/src/lua/fio.lua
> @@ -364,7 +364,7 @@ fio.mktree = function(path, mode)
>          local stat = fio.stat(current_dir)
>          if stat == nil then
>              local st, err = fio.mkdir(current_dir, mode)
> -            if err ~= nil  then
> +            if err ~= nil and not fio.path.is_dir(current_dir) then

Side note: it's weird to check the second optional result value to
detect the failure instead of the first one. Feel free to ignore.

>                  return false, string.format("Error creating directory %s: %s",
>                      current_dir, tostring(err))
>              end
> -- 
> 2.23.0
> 

[1]: https://github.com/tarantool/doc

-- 
Best regards,
IM