From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp32.i.mail.ru (smtp32.i.mail.ru [94.100.177.92]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id B218C46970E for ; Tue, 31 Dec 2019 12:12:22 +0300 (MSK) Date: Tue, 31 Dec 2019 12:12:21 +0300 From: Kirill Yukhin Message-ID: <20191231091221.ihofod4j5smgrpxl@tarantool.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Subject: Re: [Tarantool-patches] [PATCH 2/2] test: fix and split flaky join_vclock test List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ilya Kosarev Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org Hello, On 30 дек 20:47, Ilya Kosarev wrote: > join_vclock test is assumed to verify that changes are not being lost > on the replica. Due to this the test is changed to explicitly check > that all changes on master are applied on replica. > Previously this test was also indirectly verifying that changes are > being applied in the correct order. Now there is separate test for > this, called replica_apply_order. > As far as changed join_vclock test might fail due to #4669, we are now > creating cluster out of fresh instances instead of using default > instance. Considering mentioned fixes it is not fragile anymore. > > Closes #4160 I've checked your patch into 1.10, 2.2 and master. -- Regards, Kirill Yukhin