From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <korablev@tarantool.org>
Received: from smtp38.i.mail.ru (smtp38.i.mail.ru [94.100.177.98])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id A253146970E
 for <tarantool-patches@dev.tarantool.org>;
 Tue, 31 Dec 2019 02:11:24 +0300 (MSK)
Date: Tue, 31 Dec 2019 01:11:22 +0200
From: Nikita Pettik <korablev@tarantool.org>
Message-ID: <20191230231122.GD29923@tarantool.org>
References: <cover.1577724051.git.imeevma@gmail.com>
 <04a704b71ada5f801cd33d646dbb4e1e05d9bc9c.1577724051.git.imeevma@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <04a704b71ada5f801cd33d646dbb4e1e05d9bc9c.1577724051.git.imeevma@gmail.com>
Subject: Re: [Tarantool-patches] [PATCH v2 3/9] sql: remove PRAGMA
	"sql_compound_select_limit"
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: imeevma@tarantool.org
Cc: tarantool-patches@dev.tarantool.org

On 30 Dec 19:43, imeevma@tarantool.org wrote:
> diff --git a/test/sql-tap/suite.ini b/test/sql-tap/suite.ini
> index 8f3c3ea..2e8411d 100644
> --- a/test/sql-tap/suite.ini
> +++ b/test/sql-tap/suite.ini
> @@ -21,6 +21,7 @@ disabled = selectA.test.lua ;
>             analyzeE.test.lua ;
>             analyzeF.test.lua ;
>             gh-3350-skip-scan.test.lua ;
> +           gh2548-select-compound-limit.test.lua ;

This test is not only about pragma itself. Please, don't disable
it but instead refactor.
 
>  lua_libs = lua/sqltester.lua ../sql/lua/sql_tokenizer.lua ../box/lua/identifier.lua
>  is_parallel = True
> -- 
> 2.7.4
>