From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <korablev@tarantool.org>
Received: from smtp61.i.mail.ru (smtp61.i.mail.ru [217.69.128.41])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 0F4A146970E
 for <tarantool-patches@dev.tarantool.org>;
 Mon, 30 Dec 2019 16:15:19 +0300 (MSK)
Date: Mon, 30 Dec 2019 15:15:18 +0200
From: Nikita Pettik <korablev@tarantool.org>
Message-ID: <20191230131518.GA74649@tarantool.org>
References: <cover.1577455413.git.imeevma@gmail.com>
 <9b2bf828e3b58765ba76c59479a8bbd29d39b52b.1577455413.git.imeevma@gmail.com>
 <20191230112128.GO18639@tarantool.org>
 <20191230123813.GA28185@tarantool.org>
 <20191230124143.GA28330@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20191230124143.GA28330@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v5 3/3] box: add SQL settings to
	_session_settings
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Mergen Imeev <imeevma@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

On 30 Dec 15:41, Mergen Imeev wrote:
> Sorry, forgot to answer one question. The answer below.
> 
> On Mon, Dec 30, 2019 at 03:38:13PM +0300, Mergen Imeev wrote:
> > Hi! Thank you fore review! My answers below.
> > 
> > On Mon, Dec 30, 2019 at 01:21:28PM +0200, Nikita Pettik wrote:
> > > On 27 Dec 17:05, imeevma@tarantool.org wrote:
> > > > Part of #4511
> > > > 
> > > > Currently, this space contains only SQL settings, since the only
> > > > session settings are SQL settings.
> > > > 
> > > > Debug build also have debug settings that could be obtained from
> > > > this sysview:
> > > > 
> > > > sql_parser_trace
> > > > sql_select_trace
> > > > sql_trace
> > > > sql_vdbe_addoptrace
> > > > sql_vdbe_debug
> > > > sql_vdbe_eqp
> > > > sql_vdbe_listing
> > > > sql_vdbe_trace
> > > > sql_where_trace
> > > 
> > > Imho there are too many debug options. We can easily merge
> > > half of them (where + select traces, vdbe eqp + debug).
> I agree, but I suggest to leave this to the next release.
> Should I create an issue?

Why can't you do it right now? Nevertheless they are dubug
options it's not okay to release settings which are fated to
be remove the next day after release.
 
> > > What is more, I think different set of options on debug and
> > > release builds is quite error prone. Mb it is worth keeping
> > > debug options all the time, but disallow setting their values
> > > to true?
> > >
> > It is possible, but I don’t think there will be problems,
> > since there are no numerical identifiers. Still, I do not
> > think that user should be able to see internal settings.