From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <alexander.turenko@tarantool.org>
Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 5290046970E
 for <tarantool-patches@dev.tarantool.org>;
 Mon, 30 Dec 2019 11:59:49 +0300 (MSK)
Date: Mon, 30 Dec 2019 11:59:46 +0300
From: Alexander Turenko <alexander.turenko@tarantool.org>
Message-ID: <20191230085946.ikbbgpb6lspue6rh@tkn_work_nb>
References: <20191227123720.32053-1-i.kosarev@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20191227123720.32053-1-i.kosarev@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v6] test: fix flaky socket test
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Ilya Kosarev <i.kosarev@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org

Thank you!

LGTM.

WBR, Alexander Turenko.

On Fri, Dec 27, 2019 at 03:37:20PM +0300, Ilya Kosarev wrote:
> socket.test had a number of flaky problems:
> - socket readiness expectation & read timeouts
> - race conditions on socket shutdown in emulation test cases
> - UDP datagrams losses on mac os
> - excessive random port searches
> Now they are solved. 127.0.0.1 is now used instead of 0.0.0.0 or
> localhost to prevent wrong connections where appropriate. Socket test
> is not fragile anymore.
> 
> Closes #4426
> Closes #4451
> Closes #4469
> ---
> Branch: https://github.com/tarantool/tarantool/tree/i.kosarev/gh-4426-4451-fix-socket-test
> Issues: https://github.com/tarantool/tarantool/issues/4426
>         https://github.com/tarantool/tarantool/issues/4451
>         https://github.com/tarantool/tarantool/issues/4469