From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <alexander.turenko@tarantool.org>
Received: from smtp46.i.mail.ru (smtp46.i.mail.ru [94.100.177.106])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 3B81546970E
 for <tarantool-patches@dev.tarantool.org>;
 Sun, 29 Dec 2019 20:54:40 +0300 (MSK)
Date: Sun, 29 Dec 2019 20:54:38 +0300
From: Alexander Turenko <alexander.turenko@tarantool.org>
Message-ID: <20191229175438.jm2clt67birjedxe@tkn_work_nb>
References: <7f774b4348649fa5cdfb818b2e09063c865dfef4.1576767321.git.imeevma@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <7f774b4348649fa5cdfb818b2e09063c865dfef4.1576767321.git.imeevma@gmail.com>
Subject: Re: [Tarantool-patches] [PATCH 1/1] test: fix test for #4672
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Mergen Imeev <imeevma@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

I rewrote the commit message and pushed it to master, 2.2 and 1.10.

The new commit message:

 | test: trim field name update from serializer test
 |
 | The test re encoding of -2^63 Lua number value did use update by a field
 | name, which does not supported in 1.10 and 2.2 branches. Field name
 | updates are orthogonal to Lua number serialization and we don't intend
 | to test them here. So it is safe and logical to get rid of them in the
 | test.
 |
 | This change allow the test to pass on 1.10 and 2.2 branches.
 |
 | Follows up #4672.
 |
 | Reviewed-by: Alexander Tikhonov <avtikhon@tarantool.org>
 | Reviewed-by: Alexander Turenko <alexander.turenko@tarantool.org>

WBR, Alexander Turenko.

> test: fix test for #4672

Please, don't include an issue number into a commit header. A header
should describe what is changed in brief rather then provide tracking
information.

On Thu, Dec 19, 2019 at 05:56:57PM +0300, imeevma@tarantool.org wrote:
> ---
> https://github.com/tarantool/tarantool/tree/imeevma/gh-4672-fix-test-for-1.10
> 
>  test/box/gh-4672-min-integer-value-in-serializer.result   | 8 ++++----
>  test/box/gh-4672-min-integer-value-in-serializer.test.lua | 8 ++++----
>  2 files changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/test/box/gh-4672-min-integer-value-in-serializer.result b/test/box/gh-4672-min-integer-value-in-serializer.result
> index f4d7adb..a9540d9 100644
> --- a/test/box/gh-4672-min-integer-value-in-serializer.result
> +++ b/test/box/gh-4672-min-integer-value-in-serializer.result
> @@ -36,7 +36,7 @@ s:insert({3, 0})
>   | ---
>   | - [3, 0]
>   | ...
> -s:update(3, {{'=', 'i', -2^63}})
> +s:update(3, {{'=', 2, -2^63}})
>   | ---
>   | - [3, -9223372036854775808]
>   | ...
> @@ -44,7 +44,7 @@ s:insert({4, 0})
>   | ---
>   | - [4, 0]
>   | ...
> -s:update(4, {{'=', 'i', -9223372036854775808LL}})
> +s:update(4, {{'=', 2, -9223372036854775808LL}})
>   | ---
>   | - [4, -9223372036854775808]
>   | ...
> @@ -72,7 +72,7 @@ s:insert({13, 0})
>   | ---
>   | - [13, 0]
>   | ...
> -s:update(13, {{'=', 'i', -2^63}})
> +s:update(13, {{'=', 2, -2^63}})
>   | ---
>   | - [13, -9223372036854775808]
>   | ...
> @@ -80,7 +80,7 @@ s:insert({14, 0})
>   | ---
>   | - [14, 0]
>   | ...
> -s:update(14, {{'=', 'i', -9223372036854775808LL}})
> +s:update(14, {{'=', 2, -9223372036854775808LL}})
>   | ---
>   | - [14, -9223372036854775808]
>   | ...
> diff --git a/test/box/gh-4672-min-integer-value-in-serializer.test.lua b/test/box/gh-4672-min-integer-value-in-serializer.test.lua
> index f718a56..fcabb3a 100644
> --- a/test/box/gh-4672-min-integer-value-in-serializer.test.lua
> +++ b/test/box/gh-4672-min-integer-value-in-serializer.test.lua
> @@ -14,9 +14,9 @@ _ = s:create_index('ii')
>  s:insert({1, -2^63})
>  s:insert({2, -9223372036854775808LL})
>  s:insert({3, 0})
> -s:update(3, {{'=', 'i', -2^63}})
> +s:update(3, {{'=', 2, -2^63}})
>  s:insert({4, 0})
> -s:update(4, {{'=', 'i', -9223372036854775808LL}})
> +s:update(4, {{'=', 2, -9223372036854775808LL}})
>  
>  box.schema.user.grant('guest', 'read, write', 'space', 'serializer_test_space')
>  
> @@ -26,9 +26,9 @@ s = cn.space.serializer_test_space
>  s:insert({11, -2^63})
>  s:insert({12, -9223372036854775808LL})
>  s:insert({13, 0})
> -s:update(13, {{'=', 'i', -2^63}})
> +s:update(13, {{'=', 2, -2^63}})
>  s:insert({14, 0})
> -s:update(14, {{'=', 'i', -9223372036854775808LL}})
> +s:update(14, {{'=', 2, -9223372036854775808LL}})
>  
>  cn:close()
>  box.schema.user.revoke('guest', 'read, write', 'space', 'serializer_test_space')
> -- 
> 2.7.4
>