From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp37.i.mail.ru (smtp37.i.mail.ru [94.100.177.97]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id C32FE46970E for ; Sun, 29 Dec 2019 02:05:43 +0300 (MSK) Date: Sun, 29 Dec 2019 01:05:40 +0200 From: Nikita Pettik Message-ID: <20191228230540.GA44517@tarantool.org> References: <0c1ac93e3969350e6a455dbf50bacab87daf5f8b.1576074906.git.korablev@tarantool.org> <20191227170723.GL18639@tarantool.org> <20191227171415.spx4aeobyadaj4li@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20191227171415.spx4aeobyadaj4li@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH] sql: display line and position in syntax errors List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kirill Yukhin Cc: tarantool-patches@dev.tarantool.org On 27 Dec 20:14, Kirill Yukhin wrote: > On 27 дек 19:07, Nikita Pettik wrote: > > On 11 Dec 17:36, Nikita Pettik wrote: > > > When it comes for huge queries, it may turn out to be useful to see > > > exact position of occurred error. Hence, let's now display line and > > > position within line near which syntax error takes place. Note that it > > > can be done only during parsing process (since AST can be analysed only > > > after its construction is completed), so most of semantic errors still > > > don't contain position. A few errors have been reworked to match new > > > formatting patterns. > > > > > > First iteration of this patch is implemented by @romanhabibov > > > > > > Closes #2611 > > > --- > > > Branch: https://github.com/tarantool/tarantool/tree/np/gh-2611-line-pos-syntax-error > > > Issue: https://github.com/tarantool/tarantool/issues/2611 > > > v1: https://lists.tarantool.org/pipermail/tarantool-patches/2019-October/011841.html > > > > If nobody has objections (concerning new error messages patterns), > > I am going to push it. > > Sure. Pushed to master. > -- > Regards, Kirill Yukhin >