From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <korablev@tarantool.org>
Received: from smtp61.i.mail.ru (smtp61.i.mail.ru [217.69.128.41])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id C38BE46970E
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 27 Dec 2019 19:55:24 +0300 (MSK)
Date: Fri, 27 Dec 2019 18:55:22 +0200
From: Nikita Pettik <korablev@tarantool.org>
Message-ID: <20191227165522.GK18639@tarantool.org>
References: <cover.1577445318.git.imeevma@gmail.com>
 <9d98e29c55631d8fd3e817cd8bf44124303790e0.1577445318.git.imeevma@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <9d98e29c55631d8fd3e817cd8bf44124303790e0.1577445318.git.imeevma@gmail.com>
Subject: Re: [Tarantool-patches] [PATCH v5 2/5] sql: remove PRAGMA
 "short_column_names"
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: imeevma@tarantool.org
Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org

On 27 Dec 14:18, imeevma@tarantool.org wrote:
> The pragmas "short_column_names" and "full_column_names" allow us
> to use three ways to display the column name in metadata:
> 1) If both are turned off, then the column name was shown as it
> was written by the user.
> 2) If "short_column_names" = OFF and "full_column_names" = ON,
> then the column name is displayed as <table name>.<column name>.
> 3) If "short_column_names" = ON, then the column name is displayed
> as <column name>. This is the default option.

Don't get the difference between first and last options. Also see
https://www.sqlite.org/pragma.html#pragma_full_column_names
 
> But we need only two ways to show the column name:
> 1) Show the column name as <column name>. This should be the
> default option.
> 2) Show the column name as <table name>.<column name>.
> 
> In this regard, we need only one of these pragmas.
> 
> @@ -1827,12 +1824,11 @@ generate_column_metadata(struct Parse *pParse, struct SrcList *pTabList,
>  			assert(iCol >= 0 && iCol < (int)space_def->field_count);
>  			zCol = space_def->fields[iCol].name;
>  			const char *name = NULL;
> +
>  

Extra new line. Please, remove.

>			if (pEList->a[i].zName != NULL) {
>  				name = pEList->a[i].zName;
>  			} else {
> -				if (!shortNames && !fullNames) {
> -					name = pEList->a[i].zSpan;
> -				} else if (fullNames) {
> +				if (pParse->sql_flags & SQL_FullColNames) {

(pParse->sql_flags & SQL_FullColNames) != 0

>  					name = tt_sprintf("%s.%s",
>  							  space_def->name,
>  							  zCol);
> @@ -2053,8 +2049,7 @@ sqlResultSetOfSelect(Parse * pParse, Select * pSelect)
>  	sql *db = pParse->db;
>  
>  	uint32_t saved_flags = pParse->sql_flags;
> -	pParse->sql_flags |= ~SQL_FullColNames;
> -	pParse->sql_flags &= SQL_ShortColNames;
> +	pParse->sql_flags = 0;

Why do you set sql_flags to zero?

>  	sqlSelectPrep(pParse, pSelect, 0);
>  	if (pParse->is_aborted)
>  		return NULL;

I comment your patch since I've faced the same necessity to remove
short_column_names. So to avoid doubling work, I'am going to cherry-
pick your patch (or push it to the master out of order).