From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <korablev@tarantool.org>
Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 136FD46970E
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 26 Dec 2019 02:18:53 +0300 (MSK)
Date: Thu, 26 Dec 2019 02:18:52 +0300
From: Nikita Pettik <korablev@tarantool.org>
Message-ID: <20191225231852.GD18639@tarantool.org>
References: <cover.1576022424.git.korablev@tarantool.org>
 <79354099f03b9efe3a300ef4fd2c7d934876ae7b.1576071711.git.korablev@tarantool.org>
 <33e3b5df-45c3-83ff-3d0b-cbc1af6a1bae@tarantool.org>
 <20191224002621.GA31231@tarantool.org>
 <8e77686c-a97a-0781-7534-a4c556222291@tarantool.org>
 <20191225121733.GC18639@tarantool.org>
 <9632b940-5865-0fb4-a17a-693f8d4706c5@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <9632b940-5865-0fb4-a17a-693f8d4706c5@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v2 5/6] sql: extend result set with
 autoincrement
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

On 25 Dec 16:40, Vladislav Shpilevoy wrote:
> Hi!
> 
> Yes, first 5 patches are good to push.

Pushed them to master.
 
> On 25/12/2019 13:17, Nikita Pettik wrote:
> > On 24 Dec 16:30, Vladislav Shpilevoy wrote:
> >> Thanks for the patch!
> >>
> >> I've pushed my review fix on top of this commit. See it below
> >> and on the branch.
> > 
> > Thanks, I've squashed your review fixes. Are the rest of patches
> > (except last one) LGTM? If so, I'd like to push them to focus on
> > the last.
> >  
> >> commit 53fd4b3b3a27cf99c6c7a71a085574b2fd8a0dc7
> >> Author: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
> >> Date:   Tue Dec 24 15:56:24 2019 +0100
> >>
> >>     Review fix 5/6
> >>
> >> diff --git a/src/box/sql/select.c b/src/box/sql/select.c
> >> index ddb2509f4..a19494ed9 100644
> >> --- a/src/box/sql/select.c
> >> +++ b/src/box/sql/select.c
> >> @@ -1847,7 +1847,7 @@ generate_column_metadata(struct Parse *pParse, struct SrcList *pTabList,
> >>  				vdbe_metadata_set_col_nullability(v, i,
> >>  								  is_nullable);
> >>  				if (space->sequence != NULL &&
> >> -				    space->sequence_fieldno == iCol)
> >> +				    space->sequence_fieldno == (uint32_t) iCol)
> >>  					vdbe_metadata_set_col_autoincrement(v, i);
> >>  			}
> >>  		} else {