From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gorcunov@gmail.com>
Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com
 [209.85.167.42])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 53CCE46970E
 for <tarantool-patches@dev.tarantool.org>;
 Wed, 25 Dec 2019 16:11:31 +0300 (MSK)
Received: by mail-lf1-f42.google.com with SMTP id y1so16843886lfb.6
 for <tarantool-patches@dev.tarantool.org>;
 Wed, 25 Dec 2019 05:11:31 -0800 (PST)
Date: Wed, 25 Dec 2019 16:11:28 +0300
From: Cyrill Gorcunov <gorcunov@gmail.com>
Message-ID: <20191225131128.GB2463@uranus>
References: <20191219174525.13826-1-gorcunov@gmail.com>
 <20191225123606.jnufsyn4exvryn2q@tkn_work_nb>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20191225123606.jnufsyn4exvryn2q@tkn_work_nb>
Subject: Re: [Tarantool-patches] [PATCH] box/console: Handle multireturn in
	lua mode
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Alexander Turenko <alexander.turenko@tarantool.org>
Cc: tml <tarantool-patches@dev.tarantool.org>

On Wed, Dec 25, 2019 at 03:36:07PM +0300, Alexander Turenko wrote:
> Looks good in general and works correct even with nils at the end.
> 
> We however should add a test case for this, otherwise sooner or later
> we'll unable to make changes w/o fear to broke something. I propose to
> add a case with nils at the end as well as simple 1, 2, 3 multireturn.
> 
> I put several nits below. Some of them are pointed by our [Lua Style
> Guide][1], another ones are what I see across other parts of our
> codebase. My intention here is to keep the style more or less consistent
> and so make it more comfortable to work with the code (hope not only for
> me, otherwise it is not productive).
> 
> [1]: https://www.tarantool.io/en/doc/1.10/dev_guide/lua_style_guide/

Thanks! I'll update and resend together with a testcase.