From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <korablev@tarantool.org>
Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 323EA46970E
 for <tarantool-patches@dev.tarantool.org>;
 Wed, 25 Dec 2019 02:19:45 +0300 (MSK)
Date: Wed, 25 Dec 2019 02:19:43 +0300
From: Nikita Pettik <korablev@tarantool.org>
Message-ID: <20191224231943.GA18639@tarantool.org>
References: <cover.1576666151.git.k.sosnin@tarantool.org>
 <d473f962f8fddab65c0755977296e9fcdbf4036d.1576666151.git.k.sosnin@tarantool.org>
 <20191224012307.GA49851@tarantool.org>
 <400814c8-b019-11d8-1cc6-1b9a6ccbdc22@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <400814c8-b019-11d8-1cc6-1b9a6ccbdc22@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH 2/2] sql: drop only generated
 sequence in DROP TABLE
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

On 24 Dec 17:26, Vladislav Shpilevoy wrote:
> Thanks for the review!
> 
> On 24/12/2019 02:23, Nikita Pettik wrote:
> > On 18 Dec 14:00, Chris Sosnin wrote:
> >>  create mode 100644 test/sql/autoincrement.result
> >>  create mode 100644 test/sql/autoincrement.test.lua
> >>
> >> diff --git a/test/sql/autoincrement.test.lua b/test/sql/autoincrement.test.lua
> > 
> > Patch itself is LGTM (as obvious). But I am not a big fan of placing each
> > test in separate file (at least when there's no specific issue for that).
> 
> As you know, me neither. I added this new file to put here all
> autoincrement stuff now and in future. We have sql-tap/autoinc,
> but sql-tap tests are really hard to write and fix.

It's hard in comparison with sql/ suite. But in general, sql tap tests
are quite simple and easy to write (IMHO).
 
> > Moreover, in commit message it is said that this patch is follow-up to
> > #4546, so could you move this test to gh-4546-sql-drop-grants.test.lua ?
> 
> 4546 was about table grants. The test in autoincrement file about a
> different bug - drop of sequence. It is kinda related to 4546 in that
> sequence grants also should be dropped, if their sequence is deleted.

Ok, then I will simply remove 'follow-up' remark and push it to master.