From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-f67.google.com (mail-lf1-f67.google.com [209.85.167.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 1324546970E for ; Tue, 24 Dec 2019 18:33:10 +0300 (MSK) Received: by mail-lf1-f67.google.com with SMTP id 15so15356109lfr.2 for ; Tue, 24 Dec 2019 07:33:10 -0800 (PST) Date: Tue, 24 Dec 2019 18:33:08 +0300 From: Konstantin Osipov Message-ID: <20191224153308.GD30240@atlas> References: <73ebdf94c8f03fca216de9141c6541870b1ed938.1575390549.git.lvasiliev@tarantool.org> <20191203180257.GA4364@atlas> <65b9d108-fe36-1c9b-82c0-60e98efce658@tarantool.org> <20191205072706.GA16690@atlas> <442799bc-16a2-d5db-dc8c-d4663adfbe81@tarantool.org> <20191223125519.GA25824@atlas> <7b4e53cf-f2a8-1dca-4eb1-0c315f0b8932@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7b4e53cf-f2a8-1dca-4eb1-0c315f0b8932@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH] Add a cancellation guard to cpipe flush callback List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Leonid Vasiliev Cc: tarantool-patches@dev.tarantool.org * Leonid Vasiliev [19/12/24 18:30]: > > Other alternatives (which I can come up with) add possible races or > cancellation points. > We must cancel the thread before cancellation point in ev_async_send > (ev_async_send(endpoint->consumer, &endpoint->async);) and as close as > possible to it for to reproduce a behavior from > https://github.com/tarantool/tarantool/issues/4127 . I think if you add some stress component to test then it'll hit the right timing once in a while without violating encapsulation. But it's great you do have a way to reproduce at least... -- Konstantin Osipov, Moscow, Russia