From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <alexander.turenko@tarantool.org>
Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id C1B8E46970E
 for <tarantool-patches@dev.tarantool.org>;
 Mon, 23 Dec 2019 17:29:34 +0300 (MSK)
Date: Mon, 23 Dec 2019 17:29:31 +0300
From: Alexander Turenko <alexander.turenko@tarantool.org>
Message-ID: <20191223142931.72eyceez622rtt5x@tkn_work_nb>
References: <20191126151557.25754-1-sergepetrenko@tarantool.org>
 <20191210140311.p3cipmfkx44bebyn@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20191210140311.p3cipmfkx44bebyn@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH] clear terminal state on panic
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Kirill Yukhin <kyukhin@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

On Tue, Dec 10, 2019 at 05:03:11PM +0300, Kirill Yukhin wrote:
> Hello,
> 
> On 26 ноя 18:15, Serge Petrenko wrote:
> > The tarantool_free() call in the end of main() works all the time except
> > when we exit due to a panic. We need to clear terminal state in this
> > case also, so return to using atexit() to clear readline state.
> > 
> > Closes #4466
> > ---
> > https://github.com/tarantool/tarantool/issues/4466
> > https://github.com/tarantool/tarantool/tree/sp/gh-4466-clear-rl-state
> > 
> >  src/main.cc | 34 ++++++++++++++++++++++++----------
> >  1 file changed, 24 insertions(+), 10 deletions(-)

I'm okay with the change itself.

> I've checked your patch into master.

Kirill, please, propagate into all supported long-term branches: this is
the bugfix.

WBR, Alexander Turenko.