From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sergos@tarantool.org>
Received: from smtp46.i.mail.ru (smtp46.i.mail.ru [94.100.177.106])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 1489246970E
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 19 Dec 2019 18:18:00 +0300 (MSK)
Date: Thu, 19 Dec 2019 18:17:58 +0300
From: Sergey Ostanevich <sergos@tarantool.org>
Message-ID: <20191219151758.GD28206@tarantool.org>
References: <cover.1574846892.git.korablev@tarantool.org>
 <b396f9a6750eec5daa1b1e23f0cce00359c7a82c.1574846892.git.korablev@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <b396f9a6750eec5daa1b1e23f0cce00359c7a82c.1574846892.git.korablev@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH 6/6] sql: extend result set with
	alias
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Nikita Pettik <korablev@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org

Hi!

In the current branch I see the following opportunity:

diff --git a/src/box/sql/select.c b/src/box/sql/select.c
index c1770e7b4..3fc8b2f96 100644
--- a/src/box/sql/select.c
+++ b/src/box/sql/select.c
@@ -1828,12 +1828,10 @@ generate_column_metadata(struct Parse *pParse, struct SrcList *pTabList,
                        const char *name = NULL;
                        if (pEList->a[i].zName != NULL) {
                                if (is_full_meta) {
-                                       const char *alias = NULL;
+                                       const char *alias = pEList->a[i].zName;
                                        if (pEList->a[i].zSpan != NULL) {
-                                               alias = pEList->a[i].zName;
                                                name = pEList->a[i].zSpan;
                                        } else {
-                                               alias = pEList->a[i].zName;
                                                name = pEList->a[i].zName;
                                        }
                                        vdbe_metadata_set_col_alias(v, i, alias);
@@ -1868,12 +1866,10 @@ generate_column_metadata(struct Parse *pParse, struct SrcList *pTabList,
                        const char *z = NULL;
                        if (pEList->a[i].zName != NULL) {
                                if (is_full_meta ) {
-                                       const char *alias = NULL;
+                                       const char *alias = pEList->a[i].zName;
                                        if (pEList->a[i].zSpan != NULL) {
-                                               alias = pEList->a[i].zName;
                                                z = pEList->a[i].zSpan;
                                        } else {
-                                               alias = pEList->a[i].zName;
                                                z = pEList->a[i].zName;
                                        }
                                        vdbe_metadata_set_col_alias(v, i, alias);



Although, I see you have unfinished discussion on whether name should be alias 
or vice versa - I won't interrupt you.

Regards,
Sergos