From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <alexander.turenko@tarantool.org>
Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id E840C46970E
 for <tarantool-patches@dev.tarantool.org>;
 Wed, 18 Dec 2019 18:01:35 +0300 (MSK)
Date: Wed, 18 Dec 2019 18:01:32 +0300
From: Alexander Turenko <alexander.turenko@tarantool.org>
Message-ID: <20191218150132.upsy57nxmk3xpfqk@tkn_work_nb>
References: <20190723145249.5xwc2td6omphwwzw@tkn_work_nb>
 <C4BD545F-1D9F-493F-9E17-7870B015A024@tarantool.org>
 <20190828213431.3yd4kwcahe2oizgs@tkn_work_nb>
 <8E98F721-601F-436D-8F0A-5E399D8F7CAB@tarantool.org>
 <20190906134443.kc5anat2t3q26l3o@tkn_work_nb>
 <ABA786A0-DDF6-4970-828D-442298E5A64D@tarantool.org>
 <20191101151939.lewxpitqxzyn6dz6@tkn_work_nb>
 <E1252366-59AF-47C1-AB36-F24A2A1DF4AF@tarantool.org>
 <20191208194823.krw4hc4lm7bhxqrk@tkn_work_nb>
 <CC56BB52-4207-464F-9E21-BB594737CC14@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <CC56BB52-4207-464F-9E21-BB594737CC14@tarantool.org>
Subject: Re: [Tarantool-patches] [tarantool-patches] [PATCH v2 2/2] say:
 take getaddrinfo() errors into account
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Roman Khabibov <roman.habibov@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Only one comment.

unit/coio fails on FreeBSD:

[006] Test failed! Result content mismatch:
[006] --- unit/coio.result	Wed Dec 11 09:58:11 2019
[006] +++ unit/coio.reject	Wed Sep 18 08:51:42 2019
[006] @@ -1,3 +1,6 @@
[006] +#   Failed test 'getaddrinfo error message'
[006] +#   in /home/vagrant/tarantool/test/unit/coio.cc at line 100
[006] +# Looks like you failed 1 test of 3 run.
[006]  	*** stat_timeout_test ***
[006]  	*** stat_timeout_test: done ***
[006]  	*** stat_notify_test ***
[006] @@ -10,5 +13,5 @@
[006]  1..3
[006]  ok 1 - getaddrinfo
[006]  ok 2 - getaddrinfo retval
[006] -ok 3 - getaddrinfo error message
[006] +not ok 3 - getaddrinfo error message
[006]  	*** test_getaddrinfo: done ***

https://gitlab.com/tarantool/tarantool/-/jobs/375844818

Please, also push a branch with -full-ci postfix: this will run the
whole testing matrix on the branch in GitLab-CI. It worth to verify this
just in case.

WBR, Alexander Turenko.

On Tue, Dec 10, 2019 at 07:25:05PM +0300, Roman Khabibov wrote:
> Hi! Thanks for the review.