From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <imun@tarantool.org>
Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 13CF446970E
 for <tarantool-patches@dev.tarantool.org>;
 Wed, 18 Dec 2019 15:51:30 +0300 (MSK)
Date: Wed, 18 Dec 2019 15:49:19 +0300
From: Igor Munkin <imun@tarantool.org>
Message-ID: <20191218124919.GS1214@tarantool.org>
References: <cover.1575976611.git.avtikhon@tarantool.org>
 <9a38d7ec40a6b88210d829925142cc6f198de7f3.1575976611.git.avtikhon@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <9a38d7ec40a6b88210d829925142cc6f198de7f3.1575976611.git.avtikhon@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v2 2/5] static build: remove
	unneeded LD_LIBRARY_PATH
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Sasha,

Thanks for the patch! This environment variable has been added within
cb1c72d[1] and now you claim that it's excess. Could you please provide
a bit more extended rationale for the changes you've made?

On 10.12.19, Alexander V. Tikhonov wrote:
> Removed LD_LIBRARY_PATH environment from curl build, due to the
> path is empty in real and is not needed.
> ---
>  Dockerfile.staticbuild | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Dockerfile.staticbuild b/Dockerfile.staticbuild
> index 8da8ae304..343627746 100644
> --- a/Dockerfile.staticbuild
> +++ b/Dockerfile.staticbuild
> @@ -56,7 +56,7 @@ RUN set -x && \
>  
>  RUN set -x && \
>      cd / && \
> -    LD_LIBRARY_PATH=/usr/local/lib64 curl -O -L http://download.savannah.nongnu.org/releases/libunwind/libunwind-1.3-rc1.tar.gz && \
> +    curl -O -L http://download.savannah.nongnu.org/releases/libunwind/libunwind-1.3-rc1.tar.gz && \
>      tar -xvf libunwind-1.3-rc1.tar.gz && \
>      cd libunwind-1.3-rc1 && \
>      ./configure --enable-static --enable-shared && \
> -- 
> 2.17.1
> 

[1]: https://github.com/tarantool/tarantool/commit/cb1c72d

-- 
Best regards,
IM