From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <imun@tarantool.org>
Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 5656D46970E
 for <tarantool-patches@dev.tarantool.org>;
 Wed, 18 Dec 2019 15:23:38 +0300 (MSK)
Date: Wed, 18 Dec 2019 15:21:27 +0300
From: Igor Munkin <imun@tarantool.org>
Message-ID: <20191218122127.GR1214@tarantool.org>
References: <cover.1575976611.git.avtikhon@tarantool.org>
 <456b2851ac23fa58fd1498d20888e72ce67d63f7.1575976611.git.avtikhon@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <456b2851ac23fa58fd1498d20888e72ce67d63f7.1575976611.git.avtikhon@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v2 1/5] static build: speedup build
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Sasha,

Thanks, the changes LGTM except the one minor comment: I guess it's
preferable to have a sole 'build:' tag for any patch related to the
build system. Feel free to ignore and proceed if Sasha Tu. (he's already
CCed as a second reviewer) has no remarks to the subj.

On 10.12.19, Alexander V. Tikhonov wrote:
> Added '-j' option to make for tools buildings, it decreased build time in 4 times.
> ---
>  Dockerfile.staticbuild | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/Dockerfile.staticbuild b/Dockerfile.staticbuild
> index d63c18bd1..8da8ae304 100644
> --- a/Dockerfile.staticbuild
> +++ b/Dockerfile.staticbuild
> @@ -44,7 +44,7 @@ RUN set -x && \
>      tar -xvf openssl-1.1.0h.tar.gz && \
>      cd openssl-1.1.0h && \
>      ./config --libdir=lib && \
> -    make && make install
> +    make -j && make install
>  
>  RUN set -x && \
>      cd / && \
> @@ -52,7 +52,7 @@ RUN set -x && \
>      tar -xvf icu4c-62_1-src.tgz && \
>      cd icu/source && \
>      ./configure --with-data-packaging=static --enable-static --enable-shared && \
> -    make && make install
> +    make -j && make install
>  
>  RUN set -x && \
>      cd / && \
> @@ -60,7 +60,7 @@ RUN set -x && \
>      tar -xvf libunwind-1.3-rc1.tar.gz && \
>      cd libunwind-1.3-rc1 && \
>      ./configure --enable-static --enable-shared && \
> -    make && make install
> +    make -j && make install
>  
>  COPY . /tarantool
>  
> -- 
> 2.17.1
> 

-- 
Best regards,
IM