From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <alexander.turenko@tarantool.org>
Received: from smtp60.i.mail.ru (smtp60.i.mail.ru [217.69.128.40])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 8A5A646970E
 for <tarantool-patches@dev.tarantool.org>;
 Wed, 18 Dec 2019 05:02:10 +0300 (MSK)
Date: Wed, 18 Dec 2019 05:02:07 +0300
From: Alexander Turenko <alexander.turenko@tarantool.org>
Message-ID: <20191218020206.wuhr7fb3pc3qikex@tkn_work_nb>
References: <9b39fc1af6ec310ce9de99201791410fbbc00e06.1575653203.git.lvasiliev@tarantool.org>
 <eae1afc1-8ce0-cbfb-8c8e-88562f64ba05@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <eae1afc1-8ce0-cbfb-8c8e-88562f64ba05@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH] Fix queue test preparing
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Leonid Vasiliev <lvasiliev@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Expanded the commit message:

 | travis-ci: handle packagecloud's HTTP redirects
 |
 | Added curl options:
 |
 | * -L (--location) to follow Location header value from 3XX responses,
 |   because packagecloud.io redirects a GPG key request to a CDN.
 | * -s (--silent) to don't show a progress meter.
 | * -f (--fail) to fail the command at non 2XX HTTP responses. It'll fail
 |   `curl | <...>` command pipeline, since `set -o pipefail` is now
 |   enabled.
 |
 | Aside of that, fail test.sh script (and so a CI job) if something inside
 | the script fails (`set -e`) and catch mistakes from using uninitialized
 | bash variables (`set -u`) inside the script.

And pushed.

Thanks!

WBR, Alexander Turenko.

On Fri, Dec 06, 2019 at 10:18:55PM +0300, Leonid Vasiliev wrote:
> https://github.com/tarantool/queue/tree/lvasiliev/gh-noticket-fix-redirect-case
> 
> On 12/6/19 8:36 PM, Leonid Vasiliev wrote:
> > Add redirect procesing and check of a commands exit code.
> > 
> > ---
> >   test.sh | 8 +++++---
> >   1 file changed, 5 insertions(+), 3 deletions(-)
> > 
> > diff --git a/test.sh b/test.sh
> > index 3fca125..32f7567 100755
> > --- a/test.sh
> > +++ b/test.sh
> > @@ -1,15 +1,17 @@
> >   #!/bin/bash
> > +set -euo pipefail
> > +
> >   VERSION=${VERSION:-2_2}
> > -curl https://packagecloud.io/tarantool/${VERSION}/gpgkey | sudo apt-key add -
> > +curl -sfL https://packagecloud.io/tarantool/${VERSION}/gpgkey | sudo apt-key add -
> >   release=`lsb_release -c -s`
> >   sudo apt-get install -y apt-transport-https
> >   sudo tee /etc/apt/sources.list.d/tarantool_${VERSION}.list <<- EOF
> > -deb https://packagecloud.io/tarantool/${VERSION}/ubuntu/ $release main
> > -deb-src https://packagecloud.io/tarantool/${VERSION}/ubuntu/ $release main
> > +deb https://packagecloud.io/tarantool/${VERSION}/ubuntu/ ${release} main
> > +deb-src https://packagecloud.io/tarantool/${VERSION}/ubuntu/ ${release} main
> >   EOF
> >   sudo apt-get update > /dev/null
> >