From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <alexander.turenko@tarantool.org>
Received: from smtp34.i.mail.ru (smtp34.i.mail.ru [94.100.177.94])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id D96E946970E
 for <tarantool-patches@dev.tarantool.org>;
 Wed, 18 Dec 2019 04:34:52 +0300 (MSK)
Date: Wed, 18 Dec 2019 04:34:49 +0300
From: Alexander Turenko <alexander.turenko@tarantool.org>
Message-ID: <20191218013448.cwmg7cbbbfdm6fxr@tkn_work_nb>
References: <0e3de775c20f0e5776301a5b39fa1e22e0e8bdb7.1576060409.git.imeevma@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <0e3de775c20f0e5776301a5b39fa1e22e0e8bdb7.1576060409.git.imeevma@gmail.com>
Subject: Re: [Tarantool-patches] [PATCH v2 1/1] lua/serializer: encode Lua
	number -2^63 as integer
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Mergen Imeev <imeevma@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Thanks!

LGTM.

Igor, can you do second review?

WBR, Alexander Turenko.

On Wed, Dec 11, 2019 at 01:49:02PM +0300, imeevma@tarantool.org wrote:
> Hi! Thank you for review! My answers and new patch below.
> 
> https://github.com/tarantool/tarantool/issues/4672
> https://github.com/tarantool/tarantool/tree/imeevma/gh-4672-fix-min-integer-in-lua