From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <korablev@tarantool.org>
Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 323DD46970E
 for <tarantool-patches@dev.tarantool.org>;
 Tue, 17 Dec 2019 22:53:32 +0300 (MSK)
Date: Tue, 17 Dec 2019 22:53:30 +0300
From: Nikita Pettik <korablev@tarantool.org>
Message-ID: <20191217195330.GA98740@tarantool.org>
References: <cover.1574846892.git.korablev@tarantool.org>
 <1ca68695d7cd7d3d83f4b6829363ef533a23be38.1574846892.git.korablev@tarantool.org>
 <e2f296f9-a140-b9a8-c578-0fa3b006ec89@tarantool.org>
 <20191205114007.GA47637@tarantool.org>
 <23fe796e-4ea5-0438-78d6-ed9f1faafc89@tarantool.org>
 <20191206124829.GA48159@tarantool.org>
 <20191217133016.GB27451@tarantool.org>
 <20191217144429.GA88640@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20191217144429.GA88640@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH 2/6] sql: fix possible null
 dereference in sql_expr_coll()
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Sergey Ostanevich <sergos@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org, Vladislav Shpilevoy <v.shpilevoy@tarantool.org>

On 17 Dec 17:44, Nikita Pettik wrote:
> On 17 Dec 16:30, Sergey Ostanevich wrote:
> > Hi!
> > 
> > Although the patch is correct, I don't see a reason to push it as part
> > of this series. 
> > We have a bug, we have a repro - it's a standalone fix?
> 
> Without it (already existing) tests fail (from sql-tap/ suite) taking
> into consideration further patches. So this fix is required for series
> to pass all tests.

Pushed to master.
  
> > Regards,
> > Sergos
> >