From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <korablev@tarantool.org>
Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 4F45446971A
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 13 Dec 2019 16:49:21 +0300 (MSK)
Date: Fri, 13 Dec 2019 16:49:20 +0300
From: Nikita Pettik <korablev@tarantool.org>
Message-ID: <20191213134920.GA24804@tarantool.org>
References: <cover.1574277369.git.korablev@tarantool.org>
 <ef29039dfd4f45f8dc63a2497df93d95ddf942a0.1574277369.git.korablev@tarantool.org>
 <54b08743-e180-317a-3bef-391f020d4e07@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <54b08743-e180-317a-3bef-391f020d4e07@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v2 04/16] sql: rename sqlPrepare()
 to sql_compile()
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

On 03 Dec 23:51, Vladislav Shpilevoy wrote:
> Thanks for the patch!
> 
> > diff --git a/src/box/sql/sqlInt.h b/src/box/sql/sqlInt.h
> > index 3ca10778e..07c26e932 100644
> > --- a/src/box/sql/sqlInt.h
> > +++ b/src/box/sql/sqlInt.h
> > @@ -468,6 +468,19 @@ typedef void (*sql_destructor_type) (void *);
> >  #define SQL_STATIC      ((sql_destructor_type)0)
> >  #define SQL_TRANSIENT   ((sql_destructor_type)-1)
> >  
> > +/**
> > + * Compile the UTF-8 encoded SQL statement zSql into a statement handle.
> 
> Please, keep 66 symbols border, and remove 'zSql'.

diff --git a/src/box/sql/sqlInt.h b/src/box/sql/sqlInt.h
index 07c26e932..3bdbc0c38 100644
--- a/src/box/sql/sqlInt.h
+++ b/src/box/sql/sqlInt.h
@@ -469,7 +469,8 @@ typedef void (*sql_destructor_type) (void *);
 #define SQL_TRANSIENT   ((sql_destructor_type)-1)
 
 /**
- * Compile the UTF-8 encoded SQL statement zSql into a statement handle.
+ * Compile the UTF-8 encoded SQL statement into
+ * a statement handle (struct Vdbe).
  *
  * @param sql UTF-8 encoded SQL statement.
  * @param sql_len Length of @sql in bytes.>