From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <korablev@tarantool.org>
Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id ADB6346971A
 for <tarantool-patches@dev.tarantool.org>;
 Wed, 11 Dec 2019 17:23:20 +0300 (MSK)
Date: Wed, 11 Dec 2019 17:23:17 +0300
From: Nikita Pettik <korablev@tarantool.org>
Message-ID: <20191211142317.GA41096@tarantool.org>
References: <cover.1575898091.git.imeevma@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <cover.1575898091.git.imeevma@gmail.com>
Subject: Re: [Tarantool-patches] [PATCH v3 0/2] Allow to convert big real
	values to integer
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: imeevma@tarantool.org
Cc: tarantool-patches@dev.tarantool.org

On 09 Dec 16:34, imeevma@tarantool.org wrote:
> This patch-set fixes a bug that prevented the conversion of real
> values that are greater than INT64_MAX and less than UINT64_MAX to
> INTEGER and UNSIGNED.

LGTM. Pushed to master.
 
> https://github.com/tarantool/tarantool/issues/4526
> https://github.com/tarantool/tarantool/tree/imeevma/gh-4526-big-float-to-int-conversation
> 
> Mergen Imeev (2):
>   sql: refactor sqlVdbeMemIntegerify() function
>   sql: allow to convert big real values to integer
> 
>  src/box/sql/vdbe.c                 | 13 +++---
>  src/box/sql/vdbeInt.h              |  2 +-
>  src/box/sql/vdbemem.c              | 22 +++++-----
>  test/sql-tap/numcast.test.lua      | 83 +++++++++++++++++++++++++++++++++++++-
>  test/sql/integer-overflow.result   | 12 +++---
>  test/sql/integer-overflow.test.lua | 10 ++---
>  6 files changed, 113 insertions(+), 29 deletions(-)
> 
> -- 
> 2.7.4
>