From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <alexander.turenko@tarantool.org>
Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id C871546971A
 for <tarantool-patches@dev.tarantool.org>;
 Tue, 10 Dec 2019 18:35:21 +0300 (MSK)
Date: Tue, 10 Dec 2019 18:35:16 +0300
From: Alexander Turenko <alexander.turenko@tarantool.org>
Message-ID: <20191210153516.gqyydx4x6xah3mhd@tkn_work_nb>
References: <20191207131014.84735-1-olegrok@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20191207131014.84735-1-olegrok@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH] httpc: consider "verbose" option
 correctly
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Oleg Babin <olegrok@tarantool.org>
Cc: Oleg Babin <babinoleg@mail.ru>, tarantool-patches@dev.tarantool.org

LGTM.

CCed Kirill.

Kirill, this is the bugfix: please, push to all alive long-term
branches.

WBR, Alexander Turenko.

On Sat, Dec 07, 2019 at 04:10:14PM +0300, olegrok@tarantool.org wrote:
> From: Oleg Babin <babinoleg@mail.ru>
> 
> Before this patch if user passed {verbose = false}
> to http client it was considered as "true"
> 
> This patch fixes such behaviour and takes into account
> user's value

Nit: no periods at end of sentences.

> ---
>  src/lua/httpc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/lua/httpc.c b/src/lua/httpc.c
> index a8e3e2525..4d703d711 100644
> --- a/src/lua/httpc.c
> +++ b/src/lua/httpc.c
> @@ -302,7 +302,7 @@ luaT_httpc_request(lua_State *L)
>  
>  	lua_getfield(L, 5, "verbose");
>  	if (!lua_isnil(L, -1) && lua_isboolean(L, -1))
> -		httpc_set_verbose(req, true);
> +		httpc_set_verbose(req, lua_toboolean(L, -1));
>  	lua_pop(L, 1);
>  
>  	lua_getfield(L, 5, "interface");
> -- 
> 2.23.0
>