From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp14.mail.ru (smtp14.mail.ru [94.100.181.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 6CB8546971A for ; Tue, 10 Dec 2019 17:06:28 +0300 (MSK) Date: Tue, 10 Dec 2019 17:06:27 +0300 From: Kirill Yukhin Message-ID: <20191210140627.trjsqywakebvtiil@tarantool.org> References: <20191125162701.82576-1-sergepetrenko@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20191125162701.82576-1-sergepetrenko@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH] backtrace: fix out of bounds access on backtrace printing List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Serge Petrenko Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org Hello, On 25 ноя 19:27, Serge Petrenko wrote: > snrpintf always null-terminates the passed string, and it also returns > the number of bytes that "would have been written if there was enough > space", so not only we don't have to null-terminate the string, but even > more so we shouldn't do it erroneously. > > Closes #4636 > --- > https://github.com/tarantool/tarantool/issues/4636 > https://github.com/tarantool/tarantool/tree/sp/gh-4636-bt-print-fix I've checked your patch into master, 2.2 and 1.10. -- Regards, Kirill Yukhin