From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp46.i.mail.ru (smtp46.i.mail.ru [94.100.177.106]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 74C9F46971A for ; Tue, 10 Dec 2019 15:44:23 +0300 (MSK) Date: Tue, 10 Dec 2019 15:44:21 +0300 From: Kirill Yukhin Message-ID: <20191210124421.7e2jnir2mj5wdwkl@tarantool.org> References: <13437800-f8ec-1964-f7d7-a01581e242ad@tarantool.org> <20191202070715.GA27802@atlas> <20191206114244.umbeo556b2atuhjm@tarantool.org> <20191206201718.GA7299@atlas> <20191209110631.srknhyc3zpn5cjsy@tarantool.org> <20191209112428.GB25729@atlas> <20191209132555.qn25wsxoa5lr4252@tarantool.org> <20191209133955.GA8196@atlas> <20191210081958.GB21413@atlas> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20191210081958.GB21413@atlas> Subject: Re: [Tarantool-patches] [PATCH] box: remove unicode_ci for functions List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Konstantin Osipov , Vladislav Shpilevoy , Chris Sosnin , tarantool-patches@dev.tarantool.org Hello, On 10 дек 11:19, Konstantin Osipov wrote: > * Vladislav Shpilevoy [19/12/10 10:22]: > > >> We are team of Tarantool developers working for MailRU Group. > > > > > > Actually this decision was made without any discussions - it was > > > quickly hacked in back in 2018. Maybe you and Nikita had some > > > discussion prompted by Peter's firm stance that we should > > > uppercase, but that was it. I protested several times while I > > > was still on board but had not anticipated how bad the solution > > > would turn out to be when it is implemented to follow through on > > > time. Now it is still not to late - bit it's getting more late > > > every day. > > > > > > What we learned since then is that every single newbie trips over > > > it. > > > > > > > > > > Well, you was exactly the person who voted for uppercase of > > everything. Peter was for it too, but you made the decision, > > and you at that time had a right to forbid it. > > I agree I am partly to blame because I had a chance to object > and I didn't do it strongly enough at the time. > In any case, I changed my mind seeing how it worked out. This patch is not about matter which is being discussed in this thread. To discuss such major features (like `lets do everything CI`) we have `discussions` mailing list and github issues. I recommend you to move there with such proposals. The patch LGTM. I've checked it into master. -- Regards, Kirill Yukhin