From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kostja.osipov@gmail.com>
Received: from mail-lj1-f196.google.com (mail-lj1-f196.google.com
 [209.85.208.196])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 5955E46971A
 for <tarantool-patches@dev.tarantool.org>;
 Tue, 10 Dec 2019 11:21:04 +0300 (MSK)
Received: by mail-lj1-f196.google.com with SMTP id z17so18757326ljk.13
 for <tarantool-patches@dev.tarantool.org>;
 Tue, 10 Dec 2019 00:21:04 -0800 (PST)
Date: Tue, 10 Dec 2019 11:21:02 +0300
From: Konstantin Osipov <kostja.osipov@gmail.com>
Message-ID: <20191210082102.GC21413@atlas>
References: <cover.1575833120.git.v.shpilevoy@tarantool.org>
 <a5844a06bb9d4046bd8d01bf11c94ce2c8adc775.1575833120.git.v.shpilevoy@tarantool.org>
 <20191209072140.GD433@atlas>
 <a8929b96-d644-df4f-7a2b-85f28f254d8c@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <a8929b96-d644-df4f-7a2b-85f28f254d8c@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH 2/2] fiber: destroy fiber.storage
	created by iproto
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

* Vladislav Shpilevoy <v.shpilevoy@tarantool.org> [19/12/10 10:22]:
> > The danger of reporting, self-assigning and fixing a bug is that
> > ... it might be not a bug.
> 
> I agree. Except when something is obviously a bug which is
> clearly the case.
> 
> > 
> > Users should know that iproto fibers are pooled, not
> > created/destroyed on demand. So fiber local storage is simply not
> > making any sense for them.
> 
> Here I disagree. Users should not know anything about whether
> the fibers are pooled, when, and how.
> 
> If so, then please, give an example, when such a strange
> fiber.storage is needed? I just really can't come up with a
> usage case.
> 
> I did a public poll to understand what a behaviour is expected,
> and not a single person expects, that pooled vs not pooled fiber
> would affect its behaviour. Pool is like a cache. It should not
> be visible. You literally said it in another thread about SQL
> PREPARE.

You had a discussion with the community on the channel and many
people favour your fix. This is how you handle this! 

I will send a review.

-- 
Konstantin Osipov, Moscow, Russia