From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-f196.google.com (mail-lj1-f196.google.com [209.85.208.196]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 3830546971A for ; Mon, 9 Dec 2019 10:21:42 +0300 (MSK) Received: by mail-lj1-f196.google.com with SMTP id e28so14343859ljo.9 for ; Sun, 08 Dec 2019 23:21:42 -0800 (PST) Date: Mon, 9 Dec 2019 10:21:40 +0300 From: Konstantin Osipov Message-ID: <20191209072140.GD433@atlas> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Tarantool-patches] [PATCH 2/2] fiber: destroy fiber.storage created by iproto List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladislav Shpilevoy Cc: tarantool-patches@dev.tarantool.org * Vladislav Shpilevoy [19/12/08 23:47]: The danger of reporting, self-assigning and fixing a bug is that ... it might be not a bug. Users should know that iproto fibers are pooled, not created/destroyed on demand. So fiber local storage is simply not making any sense for them. A proper fix would be to disable fiber local storage for these fibers, not try to make it work. Even though your patch "works", it is pretty much useless. -- Konstantin Osipov, Moscow, Russia