From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <alexander.turenko@tarantool.org>
Received: from smtp45.i.mail.ru (smtp45.i.mail.ru [94.100.177.105])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 8AB6646971A
 for <tarantool-patches@dev.tarantool.org>;
 Mon,  9 Dec 2019 06:12:00 +0300 (MSK)
Date: Mon, 9 Dec 2019 06:11:55 +0300
From: Alexander Turenko <alexander.turenko@tarantool.org>
Message-ID: <20191209031155.iukodx2tkath4z4u@tkn_work_nb>
References: <f1e01f8132a60ef999d027d670c0ef589ec6143a.1573125147.git.avtikhon@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <f1e01f8132a60ef999d027d670c0ef589ec6143a.1573125147.git.avtikhon@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v1] gitlab-ci: cleanup submodules
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

All jobs are run in a docker or in a virtual machine. How can we get a
dirty directory for a run?

I don't mind if it solves some problems, but now I don't understand what
the problems are.

WBR, Alexander Turenko.

On Thu, Nov 07, 2019 at 02:13:46PM +0300, Alexander V. Tikhonov wrote:
> Found that durring runs on Gitlab-CI workspaces

durring -> during

> some extra files from tests from the submodules
> like src/lib/small/* leaves in subdirectories,
> which produce warning messages at the Gitlab-CI
> run log, to avoid of it the submodules cleanup

Which kind of warnings?

> it needed before each Gitlab-CI job.

it -> is?

> 
> Closes #4258

I would treat the issue as a more wide problem, then CI's one (Kirill
met it locally). I propose to left the issue open, but mention it like:

 | Follows on #4258.

> ---
> 
> Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-4258-clean-ws-full-ci
> Issue: https://github.com/tarantool/tarantool/issues/4258
> 
>  .gitlab-ci.yml | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> index 04bb4b1cc..91326b218 100644
> --- a/.gitlab-ci.yml
> +++ b/.gitlab-ci.yml
> @@ -4,6 +4,9 @@ stages:
>  variables:
>    GITLAB_MAKE: "make -f .gitlab.mk"
>  
> +before_script:
> +  - git submodule foreach git clean -xfd
> +

1. Run `git clean -xfd` too (not only submodules).
2. Add --recursive after 'foreach' just in case.
3. Enclose 'git clean -xfd' for submodules into quotes: otherwise it
   does not work on some git versions (I found that after some update).

For the reference, my one-liner that always work (at least for me):

$ git clean -xfd; git submodule foreach --recursive 'git clean -xfd'

>  # Jobs templates
>  
>  .release_only_template: &release_only_definition
> -- 
> 2.17.1
>