From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <korablev@tarantool.org> Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 1FEB946971A for <tarantool-patches@dev.tarantool.org>; Thu, 5 Dec 2019 16:37:08 +0300 (MSK) Date: Thu, 5 Dec 2019 16:37:07 +0300 From: Nikita Pettik <korablev@tarantool.org> Message-ID: <20191205133707.GB25163@tarantool.org> References: <cover.1574277369.git.korablev@tarantool.org> <d46a1ac83d35f7542ae46625b0d6082b7d6ff7d7.1574277369.git.korablev@tarantool.org> <20191204114012.GG6592@atlas> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20191204114012.GG6592@atlas> Subject: Re: [Tarantool-patches] [PATCH v2 05/16] sql: move sql_finalize() to execute.h List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org> List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe> List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/> List-Post: <mailto:tarantool-patches@dev.tarantool.org> List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help> List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe> To: Konstantin Osipov <kostja.osipov@gmail.com>, tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org On 04 Dec 14:40, Konstantin Osipov wrote: > * Nikita Pettik <korablev@tarantool.org> [19/11/21 10:00]: > > index a2c66ce00..1b0e85943 100644 > > --- a/src/box/ck_constraint.c > > +++ b/src/box/ck_constraint.c > > @@ -29,6 +29,7 @@ > > * SUCH DAMAGE. > > */ > > #include "box/session.h" > > +#include "execute.h" > > #include "bind.h" > > #include "ck_constraint.h" > > #include "errcode.h" > > All such additions require an explanation in the CS comment > otherwise they look stray. Function's declaration just has been moved to a different header, so now we have to include it to be able to use sql_finalize() > -- > Konstantin Osipov, Moscow, Russia