From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <korablev@tarantool.org>
Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id C4CBD46971A
 for <tarantool-patches@dev.tarantool.org>;
 Thu,  5 Dec 2019 16:32:44 +0300 (MSK)
Date: Thu, 5 Dec 2019 16:32:43 +0300
From: Nikita Pettik <korablev@tarantool.org>
Message-ID: <20191205133243.GA25163@tarantool.org>
References: <cover.1574277369.git.korablev@tarantool.org>
 <a8414d4ae6b728ee561c563b3167ef6eec080450.1574277369.git.korablev@tarantool.org>
 <20191204113720.GD6592@atlas>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20191204113720.GD6592@atlas>
Subject: Re: [Tarantool-patches] [PATCH v2 03/16] sql: move sql_prepare()
 declaration to box/execute.h
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Konstantin Osipov <kostja.osipov@gmail.com>, tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org

On 04 Dec 14:37, Konstantin Osipov wrote:
> * Nikita Pettik <korablev@tarantool.org> [19/11/21 10:00]:
> > index 16507b334..e3a2c77ca 100644
> > --- a/src/box/sql/legacy.c
> > +++ b/src/box/sql/legacy.c
> > @@ -37,6 +37,7 @@
> >   */
> >  
> >  #include "sqlInt.h"
> > +#include "box/execute.h"
> >  #include "box/session.h"
> 
> looks like a stray change?

No, it's not. Without it compilation fails:

/Users/n.pettik/tarantool/src/box/sql/legacy.c:73:8: error: implicit declaration of function 'sql_prepare' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
                rc = sql_prepare(zSql, -1, &pStmt, &zLeftover);
                     ^
/Users/n.pettik/tarantool/src/box/sql/legacy.c:73:8: note: did you mean 'sqlReprepare'?
/Users/n.pettik/tarantool/src/box/sql/sqlInt.h:4181:5: note: 'sqlReprepare' declared here
int sqlReprepare(Vdbe *);
    ^

Declaration of sql_prepare() is moved to box/execute.h, so to
use it in sql/legacy.c we should include box/execute.h
 
> 
> -- 
> Konstantin Osipov, Moscow, Russia