From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp16.mail.ru (smtp16.mail.ru [94.100.176.153]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id E9C7646971A for ; Thu, 5 Dec 2019 16:09:34 +0300 (MSK) Date: Thu, 5 Dec 2019 16:09:33 +0300 From: Kirill Yukhin Message-ID: <20191205130933.jfhlbpohythxiac7@tarantool.org> References: <7729408a83dbde42bc7c8a5fa1fd8ba6a7f7c40f.1575269331.git.imun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <7729408a83dbde42bc7c8a5fa1fd8ba6a7f7c40f.1575269331.git.imun@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH] fold: keep type of emitted CONV in sync with its mode List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Hello, On 02 дек 10:03, Igor Munkin wrote: > From: Vyacheslav Egorov > > When emitting CONV make sure that its type matches its destination IRType. > > This keeps IR fully internally consistent with respect to types - i.e. if > we push narrowing CONV Dt.St upwards through an arithmetic operation of type > St we end up with arithmetic operation of type Dt and two convertions > CONV Dt.St which narrow the operands. > > Igor Munkin: > * added a test for the problem > * backported the original patch to tarantool/luajit repo > * stripped some words not related to the patch itself > > Fixes LuaJIT/LuaJIT#524 > > Signed-off-by: Vyacheslav Egorov > Signed-off-by: Igor Munkin I've checked your patch into luajit repo and bumped new version in Tarantool. -- Regards, Kirill Yukhin